Skip to content

Conversation

@DiddiLeija
Copy link
Member

If pypa/sampleproject#155 gets merged, the link may get broken, and also may cause a confussion. So, this PR removes the only reference to that file, and also explained why.

If pypa/sampleproject#155 gets merged, the link may get broken, and also may cause a confussion.
@DiddiLeija
Copy link
Member Author

Ok, the tests failed:

/home/runner/work/packaging.python.org/packaging.python.org/source/guides/installing-scientific-packages.rst:16: WARNING: unknown document: scipy:stackspec
/home/runner/work/packaging.python.org/packaging.python.org/source/guides/installing-scientific-packages.rst:92: WARNING: undefined label: scipy:mac
/home/runner/work/packaging.python.org/packaging.python.org/source/guides/installing-scientific-packages.rst:101: WARNING: unknown document: scipy:install

However, this seems to be external to this PR, right?

@DiddiLeija
Copy link
Member Author

However, this seems to be external to this PR, right?

Oh, I see that #1006 wants to fix this issue.

@DiddiLeija
Copy link
Member Author

Excluding the above issue, do I have to do something else?

@webknjaz webknjaz requested a review from bhrutledge November 22, 2021 17:10
@webknjaz
Copy link
Member

@DiddiLeija wait for the reviews, I guess.

@webknjaz webknjaz enabled auto-merge November 22, 2021 19:03
@webknjaz webknjaz merged commit 16db471 into pypa:main Nov 22, 2021
@DiddiLeija DiddiLeija deleted the remove-manifest-file branch November 22, 2021 19:04
@DiddiLeija
Copy link
Member Author

Thanks @webknjaz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants