Skip to content

Conversation

@ncoghlan
Copy link
Member

This change presents twine as a CLI option for registration as well.

It also moves the note about manual .pypirc creation to the section
on creating an account, as that is needed for twine register to work.

This change presents twine as a CLI option for registration as well.

It also moves the note about manual .pypirc creation to the section
on creating an account, as that is needed for `twine register` to work.
@ncoghlan
Copy link
Member Author

@dstufft @mgedmin noted twine register wasn't covered, but in reviewing the PR at #217 I noticed several other problems with the relevant section.

This PR aims to address those as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"in order to protect"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not that great at documentation, but this is slightly wrong. It may use a plaintext HTTP connection, or it may use an unverified HTTPS connection, or it may use a verified HTTPS connection based on what version of Python you're using and/or what patches have been applied to your Python by whomever you're getting it from.

It may be over complicated to go into that much detail though and it may be preferable to be technically wrong, but simpler and safer in this documentation.

@dstufft
Copy link
Member

dstufft commented Jan 27, 2016

One comment to consider, otherwise looks good to me.

For the record, there's no need to ever use an explicit register step in Warehouse, even in legacy PyPI it's only needed once to register the project to your name, in Warehouse you don't even need it that one time.

- note misbehaviour of setup.py register/upload is version dependent
- note register is only needed on first release
- typo fix
ncoghlan added a commit that referenced this pull request Jan 27, 2016
Cover package registration via twine
@ncoghlan ncoghlan merged commit a1b80a5 into master Jan 27, 2016
@ncoghlan
Copy link
Member Author

Thanks folks - 2nd commit addressed @dstufft's and @pfmoore's comments, so I've merged this and any further changes can go in another PR.

Thanks again for the prompt to address it, @mgedmin.

@dstufft dstufft deleted the ncoghlan-twine-ref branch January 27, 2016 11:35
@mgedmin
Copy link
Contributor

mgedmin commented Jan 27, 2016

🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants