Expand the section on the "name" argument #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncoghlan
approved these changes
Jun 18, 2017
Member
ncoghlan
left a comment
ncoghlan
left a comment
There was a problem hiding this comment.
Thanks, I think this is definitely a useful improvement.
The reference to the still-in-Draft-form PEP 426 is actually outdated now, so it would make sense to update it before merging this.
| characters, see the :pep:`name <426#name>` | ||
| section from :pep:`426`. | ||
| This is the name of your project, determining how your project is listed on | ||
| :term:`PyPI <Python Package Index (PyPI)>`. Per :pep:`426`, valid project |
Member
There was a problem hiding this comment.
This can be updated to refer to the accepted PEP 508 now: https://www.python.org/dev/peps/pep-0508/#names
Member
|
Thanks! |
ncoghlan
pushed a commit
to ncoghlan/packaging.python.org
that referenced
this pull request
Jun 24, 2017
Als updates reference to be to PEP 508 instead of 426
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than referring readers to a PEP via a link that doesn't even go to the right part of the page, this patch incorporates the salient points on project names from PEPs 426 and 503 into the section on the
nameargument to thesetup()function.