Skip to content

Conversation

Pierre-Sassoulas
Copy link
Member

Require #12910 to be merged first. The first commit is a small optimization, the second commit is more opinionated / about style.

@Pierre-Sassoulas Pierre-Sassoulas marked this pull request as draft October 29, 2024 11:49
@Pierre-Sassoulas Pierre-Sassoulas added the skip news used on prs to opt out of the changelog requirement label Oct 29, 2024
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I keep getting the impression pylint keeps overdoing it on every step


return False
return any(
all(mark.kwargs.get(k, NOT_SET) == v for (k, v) in kwargs.items())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In nesting it looks worse

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, opened a pylint issue to address this.

@Pierre-Sassoulas
Copy link
Member Author

I'll have to open a new PR because the target branch disappeared :/ (already got me once, gitlab is dealing with this better and just change the target branch automatically, here I can't even do that myself after the fact)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news used on prs to opt out of the changelog requirement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants