-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[pylint consider-using-any-or-all] Fix all detected issues #12924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pylint consider-using-any-or-all] Fix all detected issues #12924
Conversation
updates: - [github.com/astral-sh/ruff-pre-commit: v0.6.9 → v0.7.0](astral-sh/ruff-pre-commit@v0.6.9...v0.7.0) - [github.com/pre-commit/mirrors-mypy: v1.11.2 → v1.12.1](pre-commit/mirrors-mypy@v1.11.2...v1.12.1) - [github.com/tox-dev/pyproject-fmt: 2.3.1 → 2.4.3](tox-dev/pyproject-fmt@2.3.1...2.4.3)
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I keep getting the impression pylint keeps overdoing it on every step
src/_pytest/mark/__init__.py
Outdated
|
||
return False | ||
return any( | ||
all(mark.kwargs.get(k, NOT_SET) == v for (k, v) in kwargs.items()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In nesting it looks worse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, opened a pylint issue to address this.
bf59ed6
to
602adde
Compare
05b72ee
to
b22f8af
Compare
cf6c0da
to
607b9f7
Compare
I'll have to open a new PR because the target branch disappeared :/ (already got me once, gitlab is dealing with this better and just change the target branch automatically, here I can't even do that myself after the fact) |
Require #12910 to be merged first. The first commit is a small optimization, the second commit is more opinionated / about style.