Skip to content

Conversation

Pierre-Sassoulas
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas commented Nov 28, 2024

Follow-up to #12875, and #12995. Lot of manual work and partial add + bissection of issues on this one. Review should be done commit by commit because there's also automated changes.

@Pierre-Sassoulas Pierre-Sassoulas added the dependencies pull requests that update a dependency file label Nov 28, 2024
@Pierre-Sassoulas Pierre-Sassoulas changed the title Upgrade ruff to 0.8.0 and fix existing issues Upgrade ruff to 0.8.1 and fix existing issues Nov 29, 2024
@Pierre-Sassoulas Pierre-Sassoulas added the skip news used on prs to opt out of the changelog requirement label Nov 29, 2024
@Pierre-Sassoulas Pierre-Sassoulas marked this pull request as draft November 29, 2024 06:51
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the pre-commit-ci-update-config branch 3 times, most recently from 5084e1b to 6313502 Compare November 29, 2024 21:34
@Pierre-Sassoulas Pierre-Sassoulas marked this pull request as ready for review November 29, 2024 21:43
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @Pierre-Sassoulas for tackling this!

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the pre-commit-ci-update-config branch from b35193a to 17c5bbb Compare November 30, 2024 13:57
@Pierre-Sassoulas Pierre-Sassoulas merged commit e087e3f into main Nov 30, 2024
28 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the pre-commit-ci-update-config branch November 30, 2024 19:30
@Pierre-Sassoulas
Copy link
Member Author

Thank you for the review and tips @nicoddemus !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file skip news used on prs to opt out of the changelog requirement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants