Skip to content

Update dependency to support suds-community #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 27, 2022

Conversation

ndobbs
Copy link
Contributor

@ndobbs ndobbs commented Nov 1, 2021

This PR attempts to resolve issue #158

While building with the latest version of fedex our ci/cd process breaks while attempting to install the dependency suds-jurko.

ERROR: Command errored out with exit status 1:
     command: /usr/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-i40r_jb8/suds-jurko/setup.py'"'"'; __file__='"'"'/tmp/pip-install-i40r_jb8/suds-jurko/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-install-i40r_jb8/suds-jurko/pip-egg-info
         cwd: /tmp/pip-install-i40r_jb8/suds-jurko/
    Complete output (1 lines):
    error in suds-jurko setup command: use_2to3 is invalid.

Upon further examination it turns out that python's setuptools drops support for 2to3 in version v.58.0.0. In order to correct this it is recommended to switch to the new and actively maintained package suds-community which already has resolved this problem HERE.

Closes #158

I have also opted to pin this dependency for future cases where the project can be more intentional with the versions expected.

@kokon
Copy link

kokon commented Nov 30, 2021

Any reasons why this is not merged?

This was referenced Nov 30, 2021
@CorainChicago
Copy link

When will this change get released?

@jpverdejo-FF
Copy link

@radzhome Any chance we can get this change approved please? Thanks

@alflanagan
Copy link

Since #160 has been merged, this should also be closed, shouldn't it? It's now a duplicate.

@jpverdejo-FF
Copy link

#160 was closed, not merged. Master branch is still using suds-jurko, so it's not a duplicate

@radzhome radzhome merged commit 8d74623 into python-fedex-devs:master Jan 27, 2022
@ndobbs ndobbs deleted the update-requirement-dep branch January 27, 2022 16:52
@CorainChicago
Copy link

Thank you! When will the next version with this change in it get released?

@ashtonpaul
Copy link

Any update on the release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch project required dependency to suds-community.
7 participants