repr() of ImportError misses keyword arguments name and path

[serhiy-storchaka]

BPO	29999
Nosy	@brettcannon, @ncoghlan, @ericsnowcurrently, @berkerpeksag, @serhiy-storchaka, @remilapeyre
PRs	gh-74185: repr() of ImportError now contains attributes name and path. #1011 bpo-27015: Save kwargs given to exceptions constructor #11580

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = None
created_at = <Date 2017-04-05.22:29:11.771>
labels = ['interpreter-core', 'type-feature', '3.7']
title = 'repr() of ImportError misses keyword arguments name and path'
updated_at = <Date 2019-01-30.16:00:33.577>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2019-01-30.16:00:33.577>
actor = 'remi.lapeyre'
assignee = 'serhiy.storchaka'
closed = False
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2017-04-05.22:29:11.771>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 29999
keywords = ['patch']
message_count = 5.0
messages = ['291200', '291241', '291633', '292205', '334569']
nosy_count = 6.0
nosy_names = ['brett.cannon', 'ncoghlan', 'eric.snow', 'berker.peksag', 'serhiy.storchaka', 'remi.lapeyre']
pr_nums = ['1011', '11580']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue29999'
versions = ['Python 3.7']

[serhiy-storchaka]

The repr of standard exceptions usually looks as exception constructor used for creating that exception. But the repr of ImportError misses keyword arguments name and path.

>>> ImportError('test', name='somename', path='somepath')
ImportError('test',)

Proposed patch make the repr of ImportError containing keyword arguments.

>>> ImportError('test', name='somename', path='somepath')
ImportError('test', name='somename', path='somepath')

I don't know how to classify this issue and whether the patch should be backported.

[brettcannon]

I consider it an enhancement, especially if someone was slopping with their tests and explicitly checks the repr of ImportError.

[serhiy-storchaka]

The patch also changes the repr of BaseException with a single argument. It no longer contains a trailing comma.

[berkerpeksag]

Including 'path' may make the repr less readable in some cases. +1 for 'name', though.

[remilapeyre]

I think the issue steems from the more general bpo-27015 for which a PR is ready that fixes the repr not only for ImportError but all other BaseException subclasses that override __init__.

[iritkatriel]

The PRs need to be updated. Marking as easy.