bpo-35100: add unquote_to_bytes_plus to the urllib.parse module #12368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add unquote_to_bytes_plus to urllib.parse module
vadmium
reviewed
Mar 16, 2019
vadmium
reviewed
Mar 17, 2019
Doc/library/urllib.parse.rst
Outdated
| .. function:: unquote_to_bytes_plus(string) | ||
|
|
||
| Like :func:`unquote_to_bytes`, but also replace plus signs by spaces, as required for | ||
| unquoting HTML form values. |
There was a problem hiding this comment.
fixed. would like me to make the same change in the docmentation for the unquote_plus() method?
|
Hey @vadmium - any chance of taking another look at this one? |
tirkarthi
reviewed
Jun 8, 2019
| @@ -575,6 +575,16 @@ task isn't already covered by the URL parsing functions above. | |||
| Example: ``unquote_to_bytes('a%26%EF')`` yields ``b'a&\xef'``. | |||
|
|
|||
|
|
|||
| .. function:: unquote_to_bytes_plus(string) | |||
There was a problem hiding this comment.
Though other functions don't have versionadded directive I think it will be good to add one to this addition. 3.8 beta 1 has been released so I am not sure if this can be merged to 3.8.
There was a problem hiding this comment.
Thanks, I've updated the docs with the versionadded directive set to 3.9, which seems the most logical.
|
This PR is stale because it has been open for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35100