-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-135335: flush stdout/stderr in forkserver after preloading modules #135338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d59b229
gh-135335: flush stdout/stderr in forkserver after preloading modules
duaneg 552266f
Attempt to fix MacOS test failures
duaneg 6e36eea
Check stderr first to get details of assertion failures
duaneg 33f9956
Further minor diagnostic improvements upon test failure
duaneg 9944968
Set start method explicitly to "forkserver" so it works on MacOS (and…
duaneg 1523e74
Address reviewer feedback: introduce some intermediate variables and …
duaneg 2125574
Update Lib/test/_test_multiprocessing.py
duaneg db298cb
Additional review feedback: add comment and align ordering
duaneg f9bab0a
Update Lib/test/mp_preload_flush.py
duaneg 4ffa138
Show default diff on unexpected stdout/err
duaneg 4d57d74
Update Lib/test/_test_multiprocessing.py
duaneg e73ea34
Update Misc/NEWS.d/next/Library/2025-06-10-21-42-04.gh-issue-135335.W…
duaneg 3f07ff7
Remove redundant check
duaneg da4df44
Don't write an newline to avoid any implicit flushes that might happen
duaneg fdb30e1
Be consistent and do not rely on asserts being enabled
duaneg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
import multiprocessing | ||
import sys | ||
|
||
modname = 'preloaded_module' | ||
if __name__ == '__main__': | ||
if modname in sys.modules: | ||
raise AssertionError(f'{modname!r} is not in sys.modules') | ||
multiprocessing.set_start_method('forkserver') | ||
multiprocessing.set_forkserver_preload([modname]) | ||
for _ in range(2): | ||
p = multiprocessing.Process() | ||
p.start() | ||
p.join() | ||
elif modname not in sys.modules: | ||
raise AssertionError(f'{modname!r} is not in sys.modules') |
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Library/2025-06-10-21-42-04.gh-issue-135335.WnUqb_.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
:mod:`multiprocessing`: Flush ``stdout`` and ``stderr`` after preloading | ||
modules in the ``forkserver``. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.