Skip to content

gh-127146: Emscripten: Fix test failure due to missing os.link #135626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2025
Merged

gh-127146: Emscripten: Fix test failure due to missing os.link #135626

merged 2 commits into from
Jun 18, 2025
+2 −2

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Jun 17, 2025 •
edited by bedevere-app bot
Loading

@hoodmane hoodmane requested a review from freakboy3742 June 17, 2025 17:07
@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Jun 17, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jun 17, 2025
Open
freakboy3742
freakboy3742 approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tweaked the keys to keep them in alphabetical order, but otherwise 👍

@freakboy3742 freakboy3742 added the needs backport to 3.14 bugs and security fixes label Jun 18, 2025
@freakboy3742 freakboy3742 enabled auto-merge (squash) June 18, 2025 02:55
@hoodmane
Copy link
Contributor Author

Thanks!

@freakboy3742 freakboy3742 merged commit ce58afb into python:main Jun 18, 2025
44 checks passed
@miss-islington-app
Copy link

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2025
@hoodmane @miss-islington
pythongh-127146: Emscripten: Fix test failure due to missing os.link (p…
9fc308a 
…ythonGH-135626)

Check for existence of os.link, rather than assuming it exists.
(cherry picked from commit ce58afb)

Co-authored-by: Hood Chatham <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jun 18, 2025

GH-135652 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 18, 2025
freakboy3742 pushed a commit that referenced this pull request Jun 18, 2025
@miss-islington @hoodmane
[3.14] gh-127146: Emscripten: Fix test failure due to missing os.link (…
a61bd7a 
…GH-135626) (#135652)

Check for existence of os.link, rather than assuming it exists.
(cherry picked from commit ce58afb)

Co-authored-by: Hood Chatham <[email protected]>
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
@hoodmane @lkollar
pythongh-127146: Emscripten: Fix test failure due to missing os.link (p…
178f909 
…ython#135626)

Check for existence of os.link, rather than assuming it exists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoodmane @freakboy3742