Skip to content

gh-119180: Only fetch globals and locals if necessary in annotationlib.get_annotations() #135644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

gh-119180: Only fetch globals and locals if necessary in annotationlib.get_annotations() #135644

merged 1 commit into from
Jun 18, 2025

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Jun 17, 2025 •
edited
Loading

A proposed small optimization. Best reviewed without whitespace: https://github.com/python/cpython/pull/135644/files?diff=split&w=1.

@Viicos Viicos requested a review from JelleZijlstra as a code owner June 17, 2025 20:45
@bedevere-app bedevere-app bot mentioned this pull request Jun 17, 2025
Open
30 tasks
@JelleZijlstra JelleZijlstra added the needs backport to 3.14 bugs and security fixes label Jun 18, 2025
@JelleZijlstra JelleZijlstra merged commit 504ae60 into python:main Jun 18, 2025
49 checks passed
@miss-islington-app
Copy link

Thanks @Viicos for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2025
@Viicos @miss-islington
pythongh-119180: Only fetch globals and locals if necessary in `annot…
6c317ec 
…ationlib.get_annotations()` (pythonGH-135644)

(cherry picked from commit 504ae60)

Co-authored-by: Victorien <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jun 18, 2025

GH-135654 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 18, 2025
JelleZijlstra pushed a commit that referenced this pull request Jun 18, 2025
@miss-islington @Viicos
[3.14] gh-119180: Only fetch globals and locals if necessary in `anno…
1429eef 
…tationlib.get_annotations()` (GH-135644) (#135654)

gh-119180: Only fetch globals and locals if necessary in `annotationlib.get_annotations()` (GH-135644)
(cherry picked from commit 504ae60)

Co-authored-by: Victorien <[email protected]>
@Viicos Viicos deleted the get-annotations-optimization branch June 18, 2025 09:03
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
@Viicos @lkollar
pythongh-119180: Only fetch globals and locals if necessary in `annot…
2a004c3 
…ationlib.get_annotations()` (python#135644)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
topic-typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Viicos @JelleZijlstra @ZeroIntensity