-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-134632: Add iOS/Android test skip for C API check for headers. #135656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
!buildbot iOS|android |
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 1998591 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135656%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Long term, we probably need to think if we don't need to support environments without development files (including without build-details.json
) in general, but testing buildbots first is important.
Agreed there's some discussion needed about how iOS/Android should be treated in this case. The contents of |
Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…s. (pythonGH-135656) iOS and Android don't ship headers in the testbed, so we can't test for their existence. (cherry picked from commit 1c7efaf) Co-authored-by: Russell Keith-Magee <[email protected]>
GH-135657 is a backport of this pull request to the 3.14 branch. |
…rs. (GH-135656) (#135657) iOS and Android don't ship headers in the testbed, so we can't test for their existence. (cherry picked from commit 1c7efaf) Co-authored-by: Russell Keith-Magee <[email protected]>
…s. (python#135656) iOS and Android don't ship headers in the testbed, so we can't test for their existence.
iOS and Android tests run in an environment where the build headers aren't visible, so testing for their existence won't work.
build-details.json
:c_api.headers
does not include thepythonX.Y
directory #134632