Skip to content

gh-135646: Raise consistent NameError exceptions in ForwardRef.evaluate() #135663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Jun 18, 2025

The error message template hasn't changed in 25 years, so the risk of them going out of sync is quite low.

@Viicos Viicos force-pushed the evaluate-fr-nameerror branch from b4843e2 to d28e0a9 Compare June 18, 2025 09:48
@JelleZijlstra JelleZijlstra added the needs backport to 3.14 bugs and security fixes label Jun 18, 2025
@JelleZijlstra JelleZijlstra enabled auto-merge (squash) June 18, 2025 13:00
@JelleZijlstra JelleZijlstra merged commit 343719d into python:main Jun 18, 2025
45 checks passed
@miss-islington-app
Copy link

Thanks @Viicos for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2025
…ef.evaluate()` (pythonGH-135663)

(cherry picked from commit 343719d)

Co-authored-by: Victorien <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jun 18, 2025

GH-135673 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 18, 2025
JelleZijlstra pushed a commit that referenced this pull request Jun 18, 2025
…Ref.evaluate()` (GH-135663) (#135673)

gh-135646: Raise consistent `NameError` exceptions in `ForwardRef.evaluate()` (GH-135663)
(cherry picked from commit 343719d)

Co-authored-by: Victorien <[email protected]>
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants