Skip to content

gh-135379: Move PyLong_CheckCompact to private header #135707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Jun 19, 2025

@encukou
Copy link
Member

encukou commented Jun 19, 2025

Since you're moving/renaming it: should this be PyLong_CheckExactAndCompact, to reduce confusion with _PyLong_IsCompact/PyUnstable_Long_IsCompact?

@Fidget-Spinner
Copy link
Member Author

Good point, I renamed it.

@Fidget-Spinner Fidget-Spinner enabled auto-merge (squash) June 19, 2025 12:30
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fidget-Spinner Fidget-Spinner merged commit 0243260 into python:main Jun 19, 2025
100 of 102 checks passed
@Fidget-Spinner Fidget-Spinner deleted the pylong_iscompact_private branch June 19, 2025 13:09
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants