-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-135532: simplify handling of HACL* errors in _hmac
#135740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-135532: simplify handling of HACL* errors in _hmac
#135740
Conversation
!buildbot FIPS only |
🤖 New build scheduled with the buildbot fleet by @picnixz for commit b7a132f 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135740%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…GH-135740) (cherry picked from commit 2dbada1) Co-authored-by: Bénédikt Tran <[email protected]>
GH-135743 is a backport of this pull request to the 3.14 branch. |
|
When I first wrote this module, I wanted to be as pedantic as possible. However, the code became overly complex and having a better traceback when getting
Hacl_Streaming_Types_InvalidAlgorithm
is not really interesting because it should, in practice, never happen.Hacl_Streaming_Types_InvalidAlgorithm
is only returned when we allocate HMAC with BLAKE-2 but... that shouldn't be possible because we're not supporting HMAC-BLAKE (BLAKE is already playing the role of a keyed hash function).