-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-59999: Add option to preserve permissions in ZipFile.extract #32289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dignissimus
wants to merge
40
commits into
python:main
Choose a base branch
from
dignissimus:bpo-15795
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
4fea41a
Add option to preserve permissions in ZipFile.extract
dignissimus f2f44ea
Update ACKS
dignissimus a09e5d3
Document option contents
dignissimus e2fa678
Document preserve_permissions parameter
dignissimus 8a056b4
Continue work on tests
dignissimus a56d934
Fix tests
dignissimus 06aff01
Skip tests on windows
dignissimus 9a4b4f6
Add news entry
dignissimus 5776f4c
Add tests for special file permissions
dignissimus 8a3a778
Re-introduce tests for mode 0
dignissimus 8a6a2c4
Use enumeration type in place of constants
dignissimus 6470201
Document enumeration type
dignissimus 5c8d82b
Check whether files were created on unix systems before extrating per…
dignissimus 89da6f2
Remove trailing whitespace
dignissimus 30e5528
Check file permissions against the umask
dignissimus 5a1edac
Document that permissions are not preserved with archives created on …
dignissimus 8a82294
Merge branch 'main' into bpo-15795
dignissimus 41a350d
minor changes
merwok 1b09aec
Merge branch 'main' into bpo-15795
dignissimus c456bb3
Qualify PreserveMode as zipfile.PreserveMode in documentation
dignissimus 5616e0a
Revert PreserveMode -> zipfile.PreserveMode in documentation
dignissimus 0065d2e
Replace dash with verb phrase in documentation for zipfile
dignissimus 4064c32
Add versionchanged note in documentation for preserve_permissions in …
dignissimus f2c816a
Qualify ZipFile method references in documentation
dignissimus 7d72b3b
Qualify zipfile.ZipFile.extract in news entry
dignissimus cb2478b
Disable tests that require root on wasi
dignissimus a082204
Disable tests that require file permissions on wasi
dignissimus fbba438
Move zipfile.PreserveMode description into docstring
dignissimus 0d6b864
Remove superfluous newline
dignissimus b466493
Align method arguments in zipfile documentation
dignissimus 9e94581
Separate clause with comma
dignissimus 500ae2e
Documentation brevity
dignissimus a81a857
Merge branch 'main' into bpo-15795
dignissimus 2cad611
Merge branch 'main' into bpo-15795
dignissimus 5ef404a
Deduplicate Zipile path and pwd parameters
dignissimus c74c006
Separate permission-setting functionality from zipfile extraction code
dignissimus 865771c
Merge branch 'main' into bpo-15795
dignissimus a2d7e77
Separate permission-setting functionality from zipfile extraction code
dignissimus 44f5c89
Merge branch 'main' into bpo-15795
dignissimus 9f5ebc3
Merge branch 'main' into bpo-15795
dignissimus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Document enumeration type
- Loading branch information
commit 6470201ce606af36ab2f9266bbb95791ea6a735b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.