-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-68443: Replace debug level-related logic in http client with logging #8633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CuriousLearner
wants to merge
18
commits into
python:main
Choose a base branch
from
CuriousLearner:fix-issue24255
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
bc7ee0b
bpo-24255: Replace debug level-related logic in http client with logging
CuriousLearner 5f63c20
fix(test_logging): Fix linting errors
CuriousLearner d45864b
fix(test/test_logging): Fix tests for HttpHandler
CuriousLearner 230784d
fix(test_httplib.py): Fix logging in tests
CuriousLearner 335a668
Revert "fix(test_logging): Fix linting errors"
CuriousLearner ed6ce82
fix test_httplib for logging
CuriousLearner d66ea05
Minor fixes
CuriousLearner c50bb33
Merge branch 'master' into fix-issue24255
CuriousLearner 76d8d5b
Minor fixes
CuriousLearner ea3b6d5
Fix tests
CuriousLearner c247e94
Prevent the alteration of test env by logging handlers
CuriousLearner 68d5f5a
Minor flake8 fixes
CuriousLearner 8c0913d
Merge branch 'master' into fix-issue24255
CuriousLearner bc49a77
bpo-24255: Fix tests
CuriousLearner 5c9062d
Minor fix in the tests
CuriousLearner 7bf6445
Merge branch 'master' into fix-issue24255
CuriousLearner bba6224
Address review comments
CuriousLearner 9933ad5
Merge branch 'master' into fix-issue24255
CuriousLearner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(test_httplib.py): Fix logging in tests
- Loading branch information
commit 230784db63752f5112c2894274b0c0c1dfcf808e
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't being used anywhere!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good catch. I think it remained here while I was working on this.