Skip to content

bpo-34171: Prevent creating Lib/trace.cover when run the trace module. #8841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2018
Merged

bpo-34171: Prevent creating Lib/trace.cover when run the trace module. #8841

merged 1 commit into from
Aug 25, 2018

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Aug 20, 2018 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.7 labels Aug 20, 2018
berkerpeksag
berkerpeksag approved these changes Aug 20, 2018
View reviewed changes
Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just tested this and it definitely doesn't generate Lib.trace.cover. Thanks!

Does this work because of the place the settrace functions are defined and called?

@berkerpeksag berkerpeksag mentioned this pull request Aug 20, 2018
Closed
@serhiy-storchaka
Copy link
Member Author

I don't know why it works. Why the line with calling sys.settrace() in _unsettrace() was added, but lines with calling _unsettrace() and exec() didn't.

@serhiy-storchaka serhiy-storchaka merged commit c406d5c into python:master Aug 25, 2018
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the trace-cover branch August 25, 2018 07:27
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 25, 2018
@serhiy-storchaka @miss-islington
bpo-34171: Prevent creating Lib/trace.cover when run the trace module. (
7088272 
pythonGH-8841)

(cherry picked from commit c406d5c)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot
Copy link

GH-8919 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Aug 25, 2018
@miss-islington @serhiy-storchaka
bpo-34171: Prevent creating Lib/trace.cover when run the trace module. (
80e9fed 
GH-8841)

(cherry picked from commit c406d5c)

Co-authored-by: Serhiy Storchaka <[email protected]>
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Aug 27, 2018
@CuriousLearner
Merge branch 'master' into fix-issue24255
c50bb33 
* master: (104 commits)
  Fast path for exact floats in math.hypot() and math.dist() (pythonGH-8949)
  Remove AIX workaround test_subprocess (pythonGH-8939)
  bpo-34503: Fix refleak in PyErr_SetObject() (pythonGH-8934)
  closes bpo-34504: Remove the useless NULL check in PySequence_Check(). (pythonGH-8935)
  closes bpo-34501: PyType_FromSpecWithBases: Check spec->name before dereferencing it. (pythonGH-8930)
  closes bpo-34502: Remove a note about utf8_mode from sys.exit() docs. (pythonGH-8928)
  Remove unneeded PyErr_Clear() in _winapi_SetNamedPipeHandleState_impl() (pythonGH-8281)
  Fix markup in stdtypes documentation (pythonGH-8905)
  bpo-34395: Don't free allocated memory on realloc fail in load_mark() in _pickle.c. (pythonGH-8788)
  Fix upsizing of marks stack in pickle module. (pythonGH-8860)
  bpo-34171: Prevent creating Lib/trace.cover when run the trace module. (pythonGH-8841)
  closes bpo-34493: Objects/genobject.c: Add missing NULL check to compute_cr_origin() (pythonGH-8911)
  Fixed typo with asynccontextmanager code example (pythonGH-8845)
  bpo-34426: fix typo (__lltrace__ -> __ltrace__) (pythonGH-8822)
  bpo-13312: Avoid int underflow in time year. (pythonGH-8912)
  bpo-34492: Python/coreconfig.c: Fix _Py_wstrlist_copy() (pythonGH-8910)
  bpo-34448: Improve output of usable wchar_t check (pythonGH-8846)
  closes bpo-34471: _datetime: Add missing NULL check to tzinfo_from_isoformat_results. (pythonGH-8869)
  bpo-6700: Fix inspect.getsourcelines for module level frames/tracebacks (pythonGH-8864)
  Fix typo in the dataclasses's doc (pythonGH-8896)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@serhiy-storchaka @miss-islington @bedevere-bot @berkerpeksag @auvipy @the-knights-who-say-ni