Skip to content

Improve message when function is missing return type #5952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JukkaL opened this issue Nov 26, 2018 · 1 comment · Fixed by #6773
Closed

Improve message when function is missing return type #5952

JukkaL opened this issue Nov 26, 2018 · 1 comment · Fixed by #6773
Labels
feature good-first-issue priority-1-normal topic-usability

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Nov 26, 2018

If a function takes no arguments (or only self) and --disallow-untyped-defs is enabled, the error message "Function is missing a type annotation" is not very helpful. Here's an idea for a better message:

foo.py:2: error: Function must have a return type annotation ('disallow_untyped_defs' enabled)
foo.py:2: note: Use "-> None" if function does not return a value

The error message could be further specialized for __init__.

See #5943 for a related issue.
@allisonking
Copy link
Contributor

I'll work on this one!

@allisonking allisonking mentioned this issue May 6, 2019
Merged
ilevkivskyi pushed a commit that referenced this issue May 9, 2019
@allisonking @ilevkivskyi
Improve message when function is missing return type (#6773)
9c74efd 
Fixes #5952

This partially relies on argument names like 'self' or 'cls', but this is OK,
since it is only used to decide the error message wording.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature good-first-issue priority-1-normal topic-usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve message when function is missing return type allisonking/mypy
2 participants
@JukkaL @allisonking