Skip to content

Make return type implicitly None for type checked __init__ and __init_subclass__ #5677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 1, 2018
Merged

Make return type implicitly None for type checked __init__ and __init_subclass__ #5677

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ea1f7da
Make return type implicitly None
onlined Sep 26, 2018
dd0b7e6
Assert for type checking
onlined Sep 26, 2018
5c6eaac
Fix import style
onlined Sep 26, 2018
2563c34
Add decorated tests
onlined Sep 26, 2018
7a82feb
Correct first parameter of __init_subclass__
onlined Sep 26, 2018
d65bb74
Add overloaded tests
onlined Sep 26, 2018
3f84608
Correct test name
onlined Sep 27, 2018
9becf45
Add explicit Any return type tests
onlined Sep 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add overloaded tests
  • Loading branch information
@onlined
onlined committed Sep 26, 2018
commit d65bb747ff597bd9f3e5dc7312fa1530fbf0632f
26 changes: 26 additions & 0 deletions test-data/unit/check-classes.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,19 @@ class A:
def __init__(self, x: int): pass
[out]

[case testOverloadedConstructorWithImplicitReturnValueType]
from foo import *
[file foo.pyi]
from typing import overload
class Foo:
@overload
def __init__(self, a: int):
pass

@overload
def __init__(self, a: str):
pass

[case testInitSubclassWithReturnValueType]
import typing
class A:
Expand All @@ -615,6 +628,19 @@ class A:
def __init_subclass__(cls, x: int=1): pass
[out]

[case testOverloadedConstructorWithImplicitReturnValueType]
from foo import *
[file foo.pyi]
from typing import overload
class Foo:
@overload
def __init_subclass__(cls, a: int):
pass

@overload
def __init_subclass__(cls, a: str):
pass

[case testGlobalFunctionInitWithReturnType]
import typing
a = __init__() # type: A
Expand Down