add missing constants #791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambv
requested changes
Dec 23, 2016
| FTP_SSL_CCC = ... # type: int | ||
| FTP_USE_EPRT = ... # type: int | ||
| FTP_USE_EPSV = ... # type: int | ||
| GLOBAL_ALL = ... # type: int |
There was a problem hiding this comment.
This is redefined from line 7. The tests complain about a few more. Make sure to ./runtests.sh locally.
|
Added the extra space. |
|
it's been a while since I did pull requests... I think it is ready for acceptance and merging into master branch. Let me know if I need to do anything else. |
|
Indeed. Happy holidays and thank you for your contribution! |
hswong3i
pushed a commit
to alvistack/python-typeshed
that referenced
this pull request
May 25, 2025
(The solution for 3.7.0 and 3.7.1 is a little funky, but those releases are dead anyways.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new constants missing.
Was causing mypy errors since it did not know E_SSL_CONNECT_ERROR.
Based on comments from gregprice, I added all of them.
(BTW, found a small typo in 'INFILESIE_LARGE' (aka needs to be 'INFILESIZE_LARGE')