Skip to content

Enable Python 3.13 in cattrs 3rd party tests #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 5, 2025

Conversation

provinzkraut
Copy link
Contributor

Was disabled because msgspec didn't support 3.13. msgspec 0.19.0 has since been released with 3.13 support, and cattrs has been updated

@AlexWaygood
Copy link
Member

Seems like there's now an exception being thrown from time-machine: https://github.com/python/typing_extensions/actions/runs/14292230292/job/40054964002?pr=577

@provinzkraut
Copy link
Contributor Author

This seems to have been fixed in time-machine 2.14.0, but I'm not sure where this dependency gets pulled in.

@AlexWaygood
Copy link
Member

Errr it probably gets installed as part of this step?

run: cd cattrs; pdm install --dev -G :all

Tbh I have no idea if that's the correct incantation for running cattrs's tests -- I've never used pdm and can't remember how I came up with that exact command when I originally wrote this workflow file! I think it was a mix of reading through pdm's docs and trial-and-error.

@provinzkraut
Copy link
Contributor Author

It's an issue with pendulum: python-pendulum/pendulum#782.
Appears to have since been fixed, but the library is waiting for a release with that fix. I'll revisit this PR once a release lands.

@AlexWaygood
Copy link
Member

Sounds good. I'll mark this PR as draft for now 👍

@AlexWaygood AlexWaygood marked this pull request as draft April 6, 2025 12:55
@python-cla-bot
Copy link

python-cla-bot bot commented Apr 6, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@AlexWaygood AlexWaygood marked this pull request as ready for review May 5, 2025 16:27
@AlexWaygood
Copy link
Member

With a couple of additional hacks, this is now passing CI!

@JelleZijlstra JelleZijlstra merged commit 2523523 into python:main May 5, 2025
73 checks passed
@provinzkraut provinzkraut deleted the enable-cattrs-313-tests branch May 5, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants