Skip to content

[CI] Install conda package from workspace #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

mthrok
Copy link
Contributor

@mthrok mthrok commented Aug 14, 2020

When running smoke test, proper way to install conda package is to
install from workspace, instead of installing from archive.
Otherwise the dependencies are not properly installed

conda/conda#1884

For this, we pass the whole conda-bld directory from
conda package build job to upload job then smoke test job.

torchaudio does not have a mandatory third-party python package dependency,
so this was not an issue.

See also pytorch/text#803

When running smoke test, proper way to install conda package is to
install from workspace, instead of installing from archive.
Otherwise the dependencies are not properly installed

conda/conda#1884

For this, we pass the whole `conda-bld` directory from
conda package build job to upload job then smoke test job.

`torchaudio` does not have a mandatory third-party python package dependency,
so this was not an issue.

See also pytorch/text#803
@mthrok mthrok requested a review from peterjc123 August 28, 2020 13:37
@mthrok mthrok marked this pull request as ready for review August 28, 2020 13:37
@mthrok mthrok requested review from seemethere and removed request for peterjc123 August 28, 2020 13:37
@mthrok mthrok merged commit ef01e24 into pytorch:master Aug 28, 2020
@mthrok
Copy link
Contributor Author

mthrok commented Aug 28, 2020

thanks!

@mthrok mthrok deleted the fix-smoke-test branch August 28, 2020 22:13
mpc001 pushed a commit to mpc001/audio that referenced this pull request Aug 4, 2023
[FX] Start fx folder and add native interpreter example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants