Consistent signature for BoTorch get_objective_weights_transform
#2200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
esantorella
force-pushed
the
export-D53706138
branch
from
7e4444b to
83bc7ae
Compare
Summary: `get_objective_weights_transform` sometimes returns a function that accepts a second argument and sometimes doesn't. Its docstring and type annotation are incorrect. This will become more problematic when we reap support for passing an `objective` with one argument to `GenericMCObjective` in pytorch#2199 Differential Revision: D53706138
esantorella
force-pushed
the
export-D53706138
branch
from
83bc7ae to
24c19bb
Compare
|
Closed as 5441833 -- not sure why this didn't auto-close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
get_objective_weights_transformsometimes returns a function that accepts a second argument and sometimes doesn't. Its docstring and type annotation are incorrect. This will become more problematic when we reap support for passing anobjectivewith one argument toGenericMCObjectivein #2199Differential Revision: D53706138