Do not count STOPPED as a model fitting failure #2767
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70994718 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2767 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 203 203
Lines 18705 18705
=======================================
Hits 18704 18704
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary: Discovered this while debugging a CUDA test failure. I don't know why this was only raised when running on GPU but it was failing model fitting with status `STOPPED` (maybe it was slower and somehow timed out in `scipy_minimize`?). Either way, we shouldn't count termination due to user specified criterion as a model fitting failure. Reviewed By: Balandat Differential Revision: D70994718
saitcakmak
force-pushed
the
export-D70994718
branch
from
f0cf58a to
b0b9473
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70994718 |
|
This pull request has been merged in f692836. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Discovered this while debugging a CUDA test failure. I don't know why this was only raised when running on GPU but it was failing model fitting with status
STOPPED(maybe it was slower and somehow timed out inscipy_minimize?).Either way, we shouldn't count termination due to user specified criterion as a model fitting failure.
Differential Revision: D70994718