Skip to content

remove daemon threads #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025
Merged

remove daemon threads #1483

merged 3 commits into from
May 9, 2025

Conversation

divyanshk
Copy link
Contributor

@divyanshk divyanshk commented May 5, 2025

This PR adds

Tested this in meta CI + Github Ci - no hanging unit tests. Will test with production job as well.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 5, 2025
Copy link

pytorch-bot bot commented May 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1483

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 5ddf4d3 with merge base 10b87d6 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@divyanshk divyanshk requested a review from ramanishsingh May 6, 2025 17:32
@divyanshk divyanshk marked this pull request as ready for review May 6, 2025 17:32
@divyanshk divyanshk force-pushed the divyanshk/daemons branch from 3794128 to 5ddf4d3 Compare May 9, 2025 00:31
@facebook-github-bot
Copy link
Contributor

@divyanshk has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@divyanshk divyanshk merged commit e58314d into main May 9, 2025
35 of 38 checks passed
@divyanshk divyanshk deleted the divyanshk/daemons branch May 9, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants