Add mps device #1018
Add mps device #1018
Conversation
|
Hi @YuliyaPylypiv! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
✅ Deploy Preview for pytorch-examples-preview canceled.
|
|
Hmm I'd be curious how many of the existing examples break with this change. I don't have an M1 and can't easily integrate into Github actions - do you mind running |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Hi @YuliyaPylypiv, thanks for your contribution! To move forward, could you resolve the conflict and @msaroufim 's comment?
YuliyaPylypiv
force-pushed
the
dev/yuliya/mps_device
branch
from
99ca83c to
3434826
Compare
YuliyaPylypiv
force-pushed
the
dev/yuliya/mps_device
branch
from
3434826 to
895f066
Compare
|
Hi @msaroufim, please see the log from |
YuliyaPylypiv
requested review from
hudeven
and removed request for
msaroufim
|
@msaroufim , are there any plans to add the M1 workflows for PyTorch examples ? We have some machines used in |
|
@hudeven , is there a bot merge command to check this in ? |
This reverts commit 616caed.
Revert "Add mps device (pytorch#1018)" This reverts commit 17fc096.
Added mps device to some networks