Skip to content

add mnist_rnn to test script for CI #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 27, 2022
Merged

add mnist_rnn to test script for CI #1086

merged 5 commits into from
Oct 27, 2022

Conversation

hudeven
Copy link
Contributor

@hudeven hudeven commented Oct 27, 2022

mnist_rnn is introduced in #752 We need to cover it in the test script for CI.

Test plan:

./run_python_examples.sh mnist_rnn

image

@hudeven hudeven requested a review from msaroufim as a code owner October 27, 2022 19:43
@netlify
Copy link

netlify bot commented Oct 27, 2022

Deploy Preview for pytorch-examples-preview canceled.

Name Link
🔨 Latest commit bd042ad
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-examples-preview/deploys/635aec007cfb380009430c66

@hudeven hudeven requested a review from bobakfb October 27, 2022 19:50
@hudeven hudeven added the testing related to unit / integration tests label Oct 27, 2022
Copy link

@bobakfb bobakfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two quick comments

Copy link

@bobakfb bobakfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hudeven hudeven merged commit 9aad148 into pytorch:main Oct 27, 2022
YinZhengxun pushed a commit to YinZhengxun/mt-exercise-02 that referenced this pull request Mar 30, 2025
* fix device mismatch issue pytorch#1071

* fix device mismatch issue pytorch#1071

* add mnist_rnn to test script for CI

* support dry_run in test()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed testing related to unit / integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants