Skip to content

Extract trace from prepare_and_convert and remove export_program #10493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

mcremon-meta
Copy link
Contributor

Summary: As titled. Will be used in later changes to fix some inconsistencies.

Differential Revision: D73440517

@mcremon-meta mcremon-meta requested a review from tarun292 as a code owner April 25, 2025 21:23
Copy link

pytorch-bot bot commented Apr 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10493

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit e822dd3 with merge base 3c21e3a (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 25, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73440517

facebook-github-bot pushed a commit that referenced this pull request Apr 29, 2025
)

Summary:

As titled. Will be used in later changes to fix some inconsistencies.

Reviewed By: zonglinpeng

Differential Revision: D73440517
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73440517

facebook-github-bot pushed a commit that referenced this pull request May 7, 2025
)

Summary:

Rewrite a test to use the graph builder and avoid API issues.

As titled. Will be used in later changes to fix some inconsistencies.

Reviewed By: zonglinpeng

Differential Revision: D73440517
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73440517

facebook-github-bot pushed a commit that referenced this pull request May 8, 2025
)

Summary:

Rewrite a test to use the graph builder and avoid API issues.

As titled. Will be used in later changes to fix some inconsistencies.

Reviewed By: zonglinpeng

Differential Revision: D73440517
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73440517

mcremon-meta added a commit that referenced this pull request May 8, 2025
)

Summary:

Rewrite a test to use the graph builder and avoid API issues.

As titled. Will be used in later changes to fix some inconsistencies.

Reviewed By: zonglinpeng

Differential Revision: D73440517
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73440517

mcremon-meta added a commit that referenced this pull request May 8, 2025
)

Summary:
Pull Request resolved: #10493

Rewrite a test to use the graph builder and avoid API issues.

As titled. Will be used in later changes to fix some inconsistencies.

Reviewed By: zonglinpeng

Differential Revision: D73440517
mcremon-meta added a commit that referenced this pull request May 8, 2025
)

Summary:

Rewrite a test to use the graph builder and avoid API issues.

As titled. Will be used in later changes to fix some inconsistencies.

Reviewed By: zonglinpeng

Differential Revision: D73440517
)

Summary:
Pull Request resolved: #10493

Rewrite a test to use the graph builder and avoid API issues.

As titled. Will be used in later changes to fix some inconsistencies.

Reviewed By: zonglinpeng

Differential Revision: D73440517
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73440517

@facebook-github-bot facebook-github-bot merged commit 5ad676d into main May 8, 2025
85 of 87 checks passed
@facebook-github-bot facebook-github-bot deleted the export-D73440517 branch May 8, 2025 22:04
jhelsby pushed a commit to jhelsby/executorch that referenced this pull request May 9, 2025
Differential Revision: D73440517

Pull Request resolved: pytorch#10493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants