Skip to content

Move EXECUTORCH_ENABLE_PROGRAM_VERIFICATION to default preset #10800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented May 10, 2025

Summary

TSIA

Test plan

CI +

$ cmake --preset macos-arm64 && cmake --build cmake-out --parallel
$ cmake -DEXECUTORCH_ENABLE_PROGRAM_VERIFICATION=OFF --preset macos-arm64 && cmake --build cmake-out --parallel
$ cmake -DEXECUTORCH_ENABLE_PROGRAM_VERIFICATION=ON --preset macos-arm64 && cmake --build cmake-out --parallel

cc @larryliu0820

@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch ciflow/trunk ciflow/binaries topic: not user facing labels May 10, 2025
Copy link

pytorch-bot bot commented May 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10800

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 2 Pending

As of commit a0291de with merge base 42b55f4 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 10, 2025
@jathu jathu force-pushed the jathu/move-EXECUTORCH_ENABLE_PROGRAM_VERIFICATION branch from 807ac79 to 2e5c610 Compare May 10, 2025 23:30
@jathu jathu force-pushed the jathu/move-EXECUTORCH_LOG_LEVEL branch from 5a8e1b2 to 72ed283 Compare May 12, 2025 16:33
@jathu jathu force-pushed the jathu/move-EXECUTORCH_ENABLE_PROGRAM_VERIFICATION branch from 2e5c610 to 836b7eb Compare May 12, 2025 16:38
@jathu jathu marked this pull request as ready for review May 12, 2025 16:51
@jathu jathu force-pushed the jathu/move-EXECUTORCH_LOG_LEVEL branch from 72ed283 to acf813c Compare May 12, 2025 17:49
Base automatically changed from jathu/move-EXECUTORCH_LOG_LEVEL to main May 12, 2025 19:32
@jathu jathu force-pushed the jathu/move-EXECUTORCH_ENABLE_PROGRAM_VERIFICATION branch from 836b7eb to a0291de Compare May 12, 2025 19:34
@jathu jathu merged commit e3a6825 into main May 12, 2025
190 of 196 checks passed
@jathu jathu deleted the jathu/move-EXECUTORCH_ENABLE_PROGRAM_VERIFICATION branch May 12, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants