-
Notifications
You must be signed in to change notification settings - Fork 613
[ET-VK][ez] enabling fp64->fp32 converison for vulkan compatibility #12201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/ahmtox/29/base
Are you sure you want to change the base?
Conversation
# Context We need this conversion so that certain operators can handle floating point values that need to be 64bit. This is predominantly applicable to choose_qparams.tensor where it expects a 64bit output. # Changes Simply adding an additional conversion for float64 to vulkan fp32. Differential Revision: [D77746137](https://our.internmc.facebook.com/intern/diff/D77746137/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12201
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit e6b67b8 with merge base 51ea3a6 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D77746137 |
This PR needs a
|
…atibility" # Context We need this conversion so that certain operators can handle floating point values that need to be 64bit. This is predominantly applicable to choose_qparams.tensor where it expects a 64bit output. # Changes Simply adding an additional conversion for float64 to vulkan fp32. Differential Revision: [D77746137](https://our.internmc.facebook.com/intern/diff/D77746137/) cc SS-JIA manuelcandales cbilgin [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D77746137 |
…atibility" # Context We need this conversion so that certain operators can handle floating point values that need to be 64bit. This is predominantly applicable to choose_qparams.tensor where it expects a 64bit output. # Changes Simply adding an additional conversion for float64 to vulkan fp32. Differential Revision: [D77746137](https://our.internmc.facebook.com/intern/diff/D77746137/) cc SS-JIA manuelcandales cbilgin [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D77746137 |
…atibility" # Context We need this conversion so that certain operators can handle floating point values that need to be 64bit. This is predominantly applicable to choose_qparams.tensor where it expects a 64bit output. # Changes Simply adding an additional conversion for float64 to vulkan fp32. Differential Revision: [D77746137](https://our.internmc.facebook.com/intern/diff/D77746137/) cc SS-JIA manuelcandales cbilgin [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D77746137 |
…atibility" # Context We need this conversion so that certain operators can handle floating point values that need to be 64bit. This is predominantly applicable to choose_qparams.tensor where it expects a 64bit output. # Changes Simply adding an additional conversion for float64 to vulkan fp32. Differential Revision: [D77746137](https://our.internmc.facebook.com/intern/diff/D77746137/) cc SS-JIA manuelcandales cbilgin [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D77746137 |
…atibility" # Context We need this conversion so that certain operators can handle floating point values that need to be 64bit. This is predominantly applicable to choose_qparams.tensor where it expects a 64bit output. # Changes Simply adding an additional conversion for float64 to vulkan fp32. Differential Revision: [D77746137](https://our.internmc.facebook.com/intern/diff/D77746137/) cc SS-JIA manuelcandales cbilgin [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D77746137 |
Stack from ghstack (oldest at bottom):
Context
We need this conversion so that certain operators can handle floating point values that need to be 64bit. This is predominantly applicable to choose_qparams.tensor where it expects a 64bit output.
Changes
Simply adding an additional conversion for float64 to vulkan fp32.
Differential Revision: D77746137
cc @SS-JIA @manuelcandales @cbilgin