-
Notifications
You must be signed in to change notification settings - Fork 610
Qualcomm AI Engine Direct - Runtime Option #12297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12297
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Cancelled Jobs, 4 Unrelated FailuresAs of commit 83b19ef with merge base 478032a ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
@@ -17,10 +17,15 @@ | |||
* Currently we assume that the outputs are all fp32 tensors. | |||
*/ | |||
|
|||
#include <executorch/backends/qualcomm/runtime/QnnBackendOptions.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it needed to have these headers?
#include <executorch/backends/qualcomm/runtime/QnnBackendOptions.h>
#include <executorch/backends/qualcomm/runtime/QnnExecuTorchBackend.h>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And these two
#include <executorch/runtime/backend/backend_option_context.h>
#include <executorch/runtime/backend/interface.h>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing the PR and catching this.
Some of these headers are not required and I have removed them.
However, QnnExecuTorchBackend.h
would still be required since the backend name variable QNN_BACKEND
is inside QnnExecuTorchBackend.h
. If there are any concerns, I can move this variable to somewhere else.
Thanks
Summary
Supporting following options that can be set during both AOT and runtime:
Test plan
debug
message prefix exists.