Skip to content

Update ExecuTorch pin to latest viable/strict 3/28/2025 (#150308) #153750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented May 16, 2025

From latest viable/strict: https://hud.pytorch.org/hud/pytorch/executorch/viable%2Fstrict/1?per_page=50

Fixes #144480

This commit has important CI stability fixes, such as pytorch/executorch#9561 and pytorch/executorch#9634

Pull Request resolved: #150308
Approved by: https://github.com/jathu, https://github.com/malfet

Copy link

pytorch-bot bot commented May 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153750

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 5 Cancelled Jobs

As of commit 27ac4a8 with merge base 924a247 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@huydhn
Copy link
Contributor Author

huydhn commented May 17, 2025

@atalman I just realize that we would need to cherry pick several changes to make this green as this ExecuTorch commit pin depends on a torchtune nightly that has been removed from the index https://github.com/pytorch/pytorch/actions/runs/15078606465/job/42392442383#step:22:611. However, I want to avoid doing so because this would mean cherry picking too many changes. So, I think it's better to temporarily add torchtune==0.6.0.dev20250310 back to the nightly index instead

@huydhn
Copy link
Contributor Author

huydhn commented May 17, 2025

@atalman Here is the index script update pytorch/test-infra#6639, I guess it's not counted as a cherry pick nor a release only change. It's a weird case

atalman pushed a commit to pytorch/test-infra that referenced this pull request May 20, 2025
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman atalman merged commit 92d3286 into release/2.7 May 21, 2025
149 of 160 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants