Skip to content

[release] Triton pin update to 3.4 #156664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[release] Triton pin update to 3.4 #156664

wants to merge 4 commits into from
+2 −2

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Jun 24, 2025 •
edited
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156664

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 2 Unrelated Failures

As of commit 07e534d with merge base 64f2ec7 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Jun 24, 2025
@jataylo jataylo added ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 labels Jun 25, 2025
atalman
atalman commented Jun 25, 2025
View reviewed changes
@atalman atalman added keep-going Don't stop on first failure, keep running tests until the end ci-no-td Do not run TD on this PR labels Jun 26, 2025
atalman
atalman commented Jun 30, 2025
View reviewed changes
@davidberard98 davidberard98 mentioned this pull request Jun 30, 2025
Open
23 tasks
@davidberard98
Copy link
Contributor

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased triton_update_2 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout triton_update_2 && git pull --rebase)

@seemethere
Copy link
Member

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased triton_update_2 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout triton_update_2 && git pull --rebase)

@davidberard98
Copy link
Contributor

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased triton_update_2 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout triton_update_2 && git pull --rebase)

@davidberard98 davidberard98 mentioned this pull request Jul 1, 2025
Open
pytorchmergebot added a commit that referenced this pull request Jul 1, 2025
@pytorchmergebot
Revert "ci: Add ability to test images for build-triton-wheel (#156894)"
3a5677a 
This reverts commit 0e47312.

Reverted #156894 on behalf of https://github.com/seemethere due to causing issues in downstream builds see #156664 for more info ([comment](#156894 (comment)))
pytorchmergebot referenced this pull request Jul 1, 2025
@seemethere @pytorchmergebot
ci: Add ability to test images for build-triton-wheel (#156894)
0e47312 
This wasn't available prior making it difficult to test if manywheel
image changes would affect triton wheel builds.

Signed-off-by: Eli Uriegas <[email protected]>
Pull Request resolved: #156894
Approved by: https://github.com/atalman, https://github.com/clee2000, https://github.com/malfet
ghstack dependencies: #156893
@davidberard98
Copy link
Contributor

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

Successfully rebased triton_update_2 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout triton_update_2 && git pull --rebase)

@atalman
Copy link
Contributor Author

atalman commented Jul 7, 2025

2 failures where disabled on CI: #157643

rocm / linux-jammy-rocm-py3.10 / test (default, 2, 6, linux.rocm.gpu.2) (gh)
inductor/test_cudagraph_trees_expandable_segments.py::CudaGraphTreeTests::test_graph_partition_forward_backward_not_called
rocm-mi300 / linux-jammy-rocm-py3.10-mi300 / test (default, 5, 6, linux.rocm.gpu.mi300.2) (gh)
inductor/test_cudagraph_trees.py::CudaGraphTreeTests::test_graph_partition_forward_backward_not_called

and not related to the triton update

@atalman atalman marked this pull request as ready for review July 7, 2025 15:34
@atalman atalman changed the title [TEST] triton Update 3.4 - 2 [release] Triton pin update to 3.4 Jul 7, 2025
@atalman
Copy link
Contributor Author

atalman commented Jul 7, 2025

@pytorchmergebot merge -f "CI signal looks good. Lint is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman
Copy link
Contributor Author

atalman commented Jul 8, 2025

@pytorchbot cherry-pick --onto release/2.8 -c critical

pytorchbot pushed a commit that referenced this pull request Jul 8, 2025
@atalman @pytorchbot
[release] Triton pin update to 3.4 (#156664)
fb87b92 
Triton pin update issue: #154206
Please see post: https://dev-discuss.pytorch.org/t/2-8-final-rc-release-postponed-by-a-week/3101

Pull Request resolved: #156664
Approved by: https://github.com/davidberard98

(cherry picked from commit 3d06ff8)
@pytorchbot
Copy link
Collaborator

Cherry picking #156664

The cherry pick PR is at #157752 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Jul 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidberard98 davidberard98 davidberard98 approved these changes

@desertfire desertfire Awaiting requested review from desertfire desertfire is a code owner

@Chillee Chillee Awaiting requested review from Chillee Chillee is a code owner

@eellison eellison Awaiting requested review from eellison eellison is a code owner

@shunting314 shunting314 Awaiting requested review from shunting314 shunting314 is a code owner

@bertmaher bertmaher Awaiting requested review from bertmaher bertmaher is a code owner

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

@jataylo jataylo Awaiting requested review from jataylo jataylo is a code owner

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd jithunnair-amd is a code owner

@pruthvistony pruthvistony Awaiting requested review from pruthvistony pruthvistony is a code owner

Assignees
No one assigned
Labels
ci-no-td Do not run TD on this PR ciflow/h100 ciflow/inductor ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/rocm Trigger "default" config CI on ROCm ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 ciflow/triton_binaries ciflow/trunk Trigger trunk jobs on your pull request keep-going Don't stop on first failure, keep running tests until the end Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@atalman @davidberard98 @pytorchmergebot @seemethere @pytorchbot @jataylo