Skip to content

[BE] add a linter to check consistency for cmake minimum version in requirements #156961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: gh/XuehaiPan/336/base
Choose a base branch
from
Open

[BE] add a linter to check consistency for cmake minimum version in requirements #156961

wants to merge 23 commits into from

Conversation

XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Jun 26, 2025 •
edited
Loading

@XuehaiPan
Update
b69b402 
[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 26, 2025
XuehaiPan added a commit that referenced this pull request Jun 26, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
0ad3b0f 
…equirements

ghstack-source-id: fc24a22
Pull-Request: #156961
This was referenced Jun 26, 2025
Closed
Closed
Closed
Closed
Open
Open
Open
@XuehaiPan XuehaiPan requested a review from malfet June 26, 2025 15:58
@XuehaiPan XuehaiPan added the better-engineering Relatively self-contained tasks for better engineering contributors label Jun 26, 2025
@XuehaiPan
Update
531410b 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 26, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156961

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

XuehaiPan added a commit that referenced this pull request Jun 26, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
91374c5 
…equirements

ghstack-source-id: 9a17d9a
Pull-Request: #156961
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 26, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156961

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9d65d13 with merge base 4ce6e6e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@XuehaiPan
Update
8c05e82 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Jun 26, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
28267a5 
…equirements

ghstack-source-id: d34a514
Pull-Request: #156961
@XuehaiPan
Update
57e3012 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Jun 26, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
f44b528 
…equirements

ghstack-source-id: f696187
Pull-Request: #156961
@XuehaiPan
Update
50b3241 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Jun 26, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
25eb793 
…equirements

ghstack-source-id: c193d7f
Pull-Request: #156961
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 26, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
695b5f1 
…equirements

ghstack-source-id: c193d7f
Pull-Request: pytorch#156961
@XuehaiPan
Update
cc945a9 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Jun 27, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
78a570d 
…equirements

ghstack-source-id: ac3c30a
Pull-Request: #156961
@XuehaiPan
Update
4f0019e 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Jun 28, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
901ef5c 
…equirements

ghstack-source-id: 8d065f9
Pull-Request: #156961
This was referenced Jun 28, 2025
Closed
Closed
@XuehaiPan
Update
1b0c79e 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Jun 30, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
0ce37dc 
…equirements

ghstack-source-id: ceda657
Pull-Request: #156961
@XuehaiPan XuehaiPan requested review from ezyang and cyyever June 30, 2025 11:34
@cyyever
Copy link
Collaborator

cyyever commented Jun 30, 2025

But CMake update is not a frequent action (3-4 years), it is not worth the check cost.

@XuehaiPan
Update
e474ef7 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Jul 1, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
ad9aa3c 
…equirements

ghstack-source-id: 3ef0ba5
Pull-Request: #156961
@XuehaiPan
Copy link
Collaborator Author

XuehaiPan commented Jul 1, 2025 •
edited
Loading

But CMake update is not a frequent action (3-4 years), it is not worth the check cost.

The linter is used to check consistency across multiple files, helping to avoid mistakes when updating the version manually.

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 1, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
49a4f8b 
…equirements

ghstack-source-id: 3ef0ba5
Pull-Request: pytorch#156961
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 1, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
a831931 
…equirements

ghstack-source-id: 3ef0ba5
Pull-Request: pytorch#156961
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 1, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
da8f55c 
…equirements

ghstack-source-id: 3ef0ba5
Pull-Request: pytorch#156961
@XuehaiPan
Update
bdeef82 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Jul 1, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
a3dcfcc 
…equirements

ghstack-source-id: 5efaa85
Pull-Request: #156961
Skylion007
Skylion007 reviewed Jul 1, 2025
View reviewed changes
tools/linter/adapters/cmake_minimum_required_linter.py
)
args = parser.parse_args()

logging.basicConfig(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: attach logging config to specific logger instead.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is copied from other files.

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 1, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
2567445 
…equirements

ghstack-source-id: 5efaa85
Pull-Request: pytorch#156961
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 1, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
40ca4a0 
…equirements

ghstack-source-id: 5efaa85
Pull-Request: pytorch#156961
@XuehaiPan
Update
ab189b4 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Jul 2, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
82397ca 
…equirements

ghstack-source-id: c95f00a
Pull-Request: #156961
@XuehaiPan XuehaiPan mentioned this pull request Jul 2, 2025
Open
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 2, 2025
@XuehaiPan @pytorchmergebot
[BE] add a linter to check consistency for cmake minimum version in r…
11d5a14 
…equirements

ghstack-source-id: c95f00a
Pull-Request: pytorch#156961
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 2, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
651f64d 
…equirements

ghstack-source-id: c95f00a
Pull-Request: pytorch#156961
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 2, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
f0970d8 
…equirements

ghstack-source-id: c95f00a
Pull-Request: pytorch#156961
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 2, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
fd00082 
…equirements

ghstack-source-id: c95f00a
Pull-Request: pytorch#156961
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 2, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
684dea1 
…equirements

ghstack-source-id: c95f00a
Pull-Request: pytorch#156961
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 2, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
3d82eac 
…equirements

ghstack-source-id: c95f00a
Pull-Request: pytorch#156961
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 2, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
5639eae 
…equirements

ghstack-source-id: c95f00a
Pull-Request: pytorch#156961
@XuehaiPan
Update
993e599 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Jul 2, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
406b160 
…equirements

ghstack-source-id: 8819a73
Pull-Request: #156961
@XuehaiPan
Update
9d65d13 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Jul 3, 2025
@XuehaiPan
[BE] add a linter to check consistency for cmake minimum version in r…
58ead41 
…equirements

ghstack-source-id: d097395
Pull-Request: #156961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

@malfet malfet Awaiting requested review from malfet

@ezyang ezyang Awaiting requested review from ezyang

@cyyever cyyever Awaiting requested review from cyyever

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuehaiPan @cyyever @Skylion007 @pytorchbot