-
Notifications
You must be signed in to change notification settings - Fork 24.6k
Use std::string_view in torchgen #157050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Use std::string_view in torchgen #157050
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157050
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit fbad1dc with merge base 039a1ce ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
1442ce7
to
0cd373a
Compare
Signed-off-by: cyy <[email protected]>
0cd373a
to
fbad1dc
Compare
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@pytorchbot revert -m "Seems to have broken internal builds, more details on D77449943. @ezyang may I count on your help to get those changes merged?" |
❌ 🤖 pytorchbot command failed:
Try |
@pytorchbot revert -m "Seems to have broken internal builds, more details on D77449943. @ezyang may I count on your help to get those changes merged?" -c ghfirst |
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit 064288c. Reverted #157050 on behalf of https://github.com/jeanschmidt due to Seems to have broken internal builds, more details on D77449943. @ezyang may I count on your help to get those changes merged? ([comment](#157050 (comment)))
@cyyever your PR has been successfully reverted. |
@jeanschmidt @ezyang I have no permission to see the report, but could they be fixed by simply using |
Let the generated code use std::sv