Skip to content

Custom vectors and refactor #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 11, 2017

Conversation

bmccann
Copy link
Contributor

@bmccann bmccann commented Sep 9, 2017

Depends on #102.

Allows users to use custom embeddings (#100).

Refactor to simplify Vectors.

@bmccann bmccann force-pushed the custom_vectors_and_refactor branch from b91290f to 5a4cd0e Compare September 9, 2017 19:44
@bmccann bmccann changed the title [WIP] Custom vectors and refactor Custom vectors and refactor Sep 9, 2017
@bmccann bmccann force-pushed the custom_vectors_and_refactor branch from 5a4cd0e to a84a66a Compare September 10, 2017 14:21
@bmccann bmccann requested a review from jekbradbury September 11, 2017 10:31
@bmccann bmccann force-pushed the custom_vectors_and_refactor branch from a84a66a to eea3d33 Compare September 11, 2017 12:49
@bmccann bmccann merged commit c821499 into pytorch:master Sep 11, 2017
expand_vocab (bool): expand vocabulary to include all words for which
the specified pretrained word vectors are available
vectors: one of or a list containing instantiations of the
GloVe, CharNGram, or Vectors classes

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants