Make version static text into a link to versions.html #1161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1161 +/- ##
==========================================
+ Coverage 79.11% 79.63% +0.51%
==========================================
Files 65 47 -18
Lines 3563 3201 -362
==========================================
- Hits 2819 2549 -270
+ Misses 744 652 -92
Continue to review full report at Codecov.
|
|
A comment not relevant to this PR - I found the font of torchtext website is not consistent with audio/vision. We use bold everywhere http://pytorch.org/text/stable/index.html while audio/vision don't https://pytorch.org/audio/stable/index.html. I guess we don't use the sphinx correctly. @mattip |
|
I’ll check it out when I get a chance. We install the theme through requirements.txt during the doc build so it should be the same. Thanks!
…________________________________
From: Guanheng George Zhang <[email protected]>
Sent: Monday, February 22, 2021 6:51:02 PM
To: pytorch/text <[email protected]>
Cc: Brian Johnson <[email protected]>; Mention <[email protected]>
Subject: Re: [pytorch/text] Make version static text into a link to versions.html (#1161)
A comment not relevant to this PR - I found the font of torchtext website is not consistent with audio/vision. We use bold everywhere http://pytorch.org/text/stable/index.html<http://pytorch.org/text/stable/index.html> while audio/vision don't https://pytorch.org/audio/stable/index.html<https://pytorch.org/audio/stable/index.html>. I guess we don't use the sphinx correctly. @mattip<https://github.com/mattip>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1161 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALOH5M2QU7DNA3OFKB2H33TALUWNANCNFSM4XWPILVA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1160 to turn the static version text into a link to the manually-maintained versions.html page to allow selecting a version of the documentation to view. Once this is merged, the next nightly document build and push will make this work with the
masterdocumentation