Skip to content

[BC-breaking] Split raw sequence tagging datasets into individual files #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 18, 2021

Conversation

cpuhrsch
Copy link
Contributor

@cpuhrsch cpuhrsch commented Feb 18, 2021

Follow-up to https://github.com/pytorch/text/pull/1156/files#

To further align the dataset organization of the raw datasets with the other domain libraries (torchaudio and torchvision) we split them into separate files, one each per dataset. This PR introduces this change for all sequence tagging datasets. It is BC-breaking in the sense that the torchtext.experimental.datasets.raw.translation module is being removed.

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #1176 (03b969b) into master (2f37809) will increase coverage by 0.06%.
The diff coverage is 95.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1176      +/-   ##
==========================================
+ Coverage   76.99%   77.05%   +0.06%     
==========================================
  Files          69       70       +1     
  Lines        3612     3631      +19     
==========================================
+ Hits         2781     2798      +17     
- Misses        831      833       +2     
Impacted Files Coverage Δ
torchtext/experimental/datasets/raw/udpos.py 94.44% <94.44%> (ø)
...ext/experimental/datasets/raw/conll2000chunking.py 94.73% <94.73%> (ø)
torchtext/experimental/datasets/raw/__init__.py 100.00% <100.00%> (ø)
torchtext/experimental/datasets/raw/common.py 83.33% <0.00%> (-1.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f37809...03b969b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants