-
Notifications
You must be signed in to change notification settings - Fork 812
[BC-breaking] Split raw sequence tagging datasets into individual files #1176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+157
−168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangguanheng66
approved these changes
Feb 18, 2021
Codecov Report
@@ Coverage Diff @@
## master #1176 +/- ##
==========================================
+ Coverage 76.99% 77.05% +0.06%
==========================================
Files 69 70 +1
Lines 3612 3631 +19
==========================================
+ Hits 2781 2798 +17
- Misses 831 833 +2
Continue to review full report at Codecov.
|
This was referenced Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to https://github.com/pytorch/text/pull/1156/files#
To further align the dataset organization of the raw datasets with the other domain libraries (torchaudio and torchvision) we split them into separate files, one each per dataset. This PR introduces this change for all sequence tagging datasets. It is BC-breaking in the sense that the torchtext.experimental.datasets.raw.translation module is being removed.