Skip to content

Shorten Multi30k code by generating docstring #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 18, 2021

Conversation

cpuhrsch
Copy link
Contributor

Reduces the code by about 60 lines by adding the option of including docstring to the header decorator

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #1185 (970edfb) into master (3e05f58) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1185      +/-   ##
==========================================
+ Coverage   77.70%   77.88%   +0.17%     
==========================================
  Files          65       65              
  Lines        3571     3585      +14     
==========================================
+ Hits         2775     2792      +17     
+ Misses        796      793       -3     
Impacted Files Coverage Δ
torchtext/datasets/common.py 88.76% <100.00%> (+4.24%) ⬆️
torchtext/datasets/multi30k.py 96.42% <100.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e05f58...970edfb. Read the comment docs.

@cpuhrsch cpuhrsch merged commit a22a73b into pytorch:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants