Remove the step to clean the cache for test_iwslt #1192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangguanheng66
changed the title
cpuhrsch
reviewed
Feb 19, 2021
test/data/test_builtin_datasets.py
Outdated
| @@ -267,39 +267,40 @@ def test_imdb(self): | |||
| self._helper_test_func(len(test_iter), 25000, next(test_iter)[1][:25], 'I love sci-fi and am will') | |||
| del train_iter, test_iter | |||
|
|
|||
| def test_iwslt(self): | |||
There was a problem hiding this comment.
To explicitly disable a test like this you can use unittest.skip
There was a problem hiding this comment.
Yup. I forget this. Let me re-send it.
cpuhrsch
approved these changes
Feb 19, 2021
zhangguanheng66
force-pushed
the
disable_test_iwslt
branch
from
933e534 to
68b9b0d
Compare
zhangguanheng66
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.