fix tag build so it triggers prerequisites #1332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to see this merged before the next tag event, to make sure the docs are now building (the last few tags did not generate docs) |
|
I am pretty sure this needs to be backported to the 0.10 branch |
malfet
approved these changes
Jul 26, 2021
|
Looks like this merge is causing build_docs to fail? https://app.circleci.com/pipelines/github/pytorch/text/3664/workflows/4a92d4fa-4cbc-46da-af5b-b5d75176acc9/jobs/116759 @malfet @mattip |
|
I don't think this PR could have broken anything, it just docs build has not been running for non-tagged builds. Looking into the failures now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port pytorch/vision#3998 and pytorch/vision#4053 so that adding a tag will trigger a documentation build-and-upload. The problem was that the upload depends on both the wheel and the build_docs builds, but those did not have the correct filter so they were not running.