Skip to content

[BUG-FIX] fix penn dataset #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2022
Merged

[BUG-FIX] fix penn dataset #1552

merged 1 commit into from
Jan 28, 2022

Conversation

parmeet
Copy link
Contributor

@parmeet parmeet commented Jan 28, 2022

This PR fix the bug in writing downloaded file to disk. It need be dumped as binary ('wb') and not as text/string ('w').

Copy link
Contributor

@abhinavarora abhinavarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nayef211 Nayef211 merged commit 9561cde into pytorch:main Jan 28, 2022
@parmeet parmeet deleted the fix_penn branch January 30, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants