fixes platform-dependent expectation for Multi30k mocked test. #1593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That would certainly be less kludgy! 🤣 I've repurposed this PR. |
erip
force-pushed
the
hotfix/multi30k-test
branch
from
990f981 to
e2b1550
Compare
parmeet
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests currently fail on Windows because multi30k doesn't strip newlines and therefore the file is read with carriage returns:
"ABCD\r\n" != "ABC\n". This fixes the bug by stripping newlines from Multi30k to be consistent with other datasets.Technically this is a BC and users can revert it in userland code by appending
os.linesepto each line as needed.