Skip to content

Parameterize tests for similar datasets #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 10, 2022
Merged

Parameterize tests for similar datasets #1600

merged 3 commits into from
Feb 10, 2022

Conversation

Nayef211
Copy link
Contributor

Reference Issue: #1493

Description

  • Parameterize Amazon dataset tests
  • Deleted YelpReviewFull test since it's already parameterized
  • Renamed Squad test for consistency

Testing

  • pytest -s test_amazonreviews.py
  • pytest -s test_squads.py

@Nayef211 Nayef211 requested review from vcm2114 and parmeet February 10, 2022 22:59
This was referenced Feb 10, 2022
Closed
Merged
vcm2114
vcm2114 approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@vcm2114 vcm2114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The standardization of the mock unit tests is nice!

@Nayef211 Nayef211 merged commit 08f49f9 into pytorch:main Feb 10, 2022
@Nayef211 Nayef211 deleted the test/parameterize_dataset_tests branch February 10, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcm2114 vcm2114 vcm2114 approved these changes

@parmeet parmeet Awaiting requested review from parmeet

Assignees
No one assigned
Labels
ciflow/default cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nayef211 @vcm2114 @facebook-github-bot