[fbsync] Remove unneeded modules after using nn.Module for BetterTransformer #1696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: pytorch#1690 This diff created a fast path of using better transformer (torch.nn.TransformerEncoderLayer), with a converter from the existing torchtext transformer encoder layer to better transforomer. The related tests are added in the following diff. Reviewed By: parmeet Differential Revision: D35948440 fbshipit-source-id: e69e12f2dd28edfea3176a10ee3d7d321d50c897
Summary: Fully remove to_better method by rebuild torchtext TransformerEncoderLayer's load_from_state_dict and init. No more redundant params. Reviewed By: parmeet Differential Revision: D36020184 fbshipit-source-id: ccdd6da853a86034762b235cd7d5f793876d16c6
…ytorch#1693) Summary: Pull Request resolved: pytorch#1693 Remove unneeded modules after using nn.Module for BetterTransformer Reviewed By: zrphercule Differential Revision: D36038830 fbshipit-source-id: 1e0f5c7cf81096cf66cc1afcf15b5e0645c3da03
Nayef211
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request resolved: #1693
Remove unneeded modules after using nn.Module for BetterTransformer
Reviewed By: zrphercule
Differential Revision: D36038830
fbshipit-source-id: 1e0f5c7cf81096cf66cc1afcf15b5e0645c3da03