Updating dataset code to avoid creating multiple iterators from a DataPipe #1708
+15
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NivekT
commented
May 10, 2022
| cache_decompressed_dp = cache_decompressed_dp.end_caching(mode="wb", same_filepath_fn=True) | ||
| cache_decompressed_dp_1, cache_decompressed_dp_2 = cache_decompressed_dp.fork(num_instances=2) |
There was a problem hiding this comment.
The recommended pattern is to use fork when you need the same DataPipe for multiple usages later.
| @@ -125,7 +125,7 @@ | |||
| # avoid additional conditional imports. | |||
| def _filter_clean_cache(cache_decompressed_dp, full_filepath, uncleaned_filename): | |||
| cache_inner_decompressed_dp = cache_decompressed_dp.on_disk_cache(filepath_fn=lambda x: full_filepath) | |||
| cache_inner_decompressed_dp = FileOpener(cache_inner_decompressed_dp, mode="b").load_from_tar() | |||
| cache_inner_decompressed_dp = cache_inner_decompressed_dp.open_files(mode="b").load_from_tar() | |||
There was a problem hiding this comment.
FYI, we recently added .open_files as the functional form of FileOpener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will be introducing a change in
torch/torchdatato prevent users from creating multiple iterators from a single DataPipe. In order to not break anything when it lands, this PR update certain DataPipe use cases to avoid creating multiple iterators from a DataPipe. This should not impact any functionality.Let me know if there are usages of DataPipes outside of
torchtext/datasets.