Skip to content

Rename build_tools dir to tools dir #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2022
Merged

Rename build_tools dir to tools dir #1804

merged 2 commits into from
Jun 23, 2022

Conversation

mthrok
Copy link
Contributor

@mthrok mthrok commented Jun 23, 2022

  • To align with PyTorch core and other repos.
  • Python creates build directory, so build_tools required one more tab completion.

@mthrok
Rename build_tools dir to tools dir
03669fe 
* To align with PyTorch core and other repos.
* Python creates build directory, so build_tools required one more tab completion.
parmeet
parmeet approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@parmeet parmeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mthrok for the fix. LGTM!

@mthrok mthrok merged commit e023ce1 into pytorch:main Jun 23, 2022
@mthrok mthrok deleted the tools-dir branch June 23, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parmeet parmeet parmeet approved these changes

@Nayef211 Nayef211 Nayef211 approved these changes

Assignees
No one assigned
Labels
BE hackathon cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mthrok @parmeet @Nayef211 @facebook-github-bot