Skip to content

[Cherry Pick] Turn off mask checking for torchtext which is known to have a legal mask (#1896) #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

Nayef211
Copy link
Contributor

@Nayef211 Nayef211 commented Sep 15, 2022

Summary:
Pull Request resolved: #1896

Turn off mask checking for torchtext which is known to have a legal mask

Reviewed By: zrphercule

Differential Revision: D39445703

fbshipit-source-id: 3f0cacfd39ea11a16c7a06f339872554333b5e97

…ask (pytorch#1896)

Summary:
Pull Request resolved: pytorch#1896

Turn off mask checking for torchtext which is known to have a legal mask

Reviewed By: zrphercule

Differential Revision: D39445703

fbshipit-source-id: 3f0cacfd39ea11a16c7a06f339872554333b5e97
@Nayef211 Nayef211 changed the title Turn off mask checking for torchtext which is known to have a legal m… [Cherry Pick] Turn off mask checking for torchtext which is known to have a legal mask (#1896) Sep 15, 2022
@Nayef211 Nayef211 marked this pull request as ready for review September 15, 2022 20:39
@joecummings
Copy link
Contributor

Can we create an Issue to track this recurring test failure on MacOS?

OSError: [Errno 28] No space left on device

@Nayef211
Copy link
Contributor Author

Can we create an Issue to track this recurring test failure on MacOS?

OSError: [Errno 28] No space left on device

We can, but the error is also already resolved in #1889 which should be landing sometime today or tomorrow.

@joecummings
Copy link
Contributor

Can we create an Issue to track this recurring test failure on MacOS?

OSError: [Errno 28] No space left on device

We can, but the error is also already resolved in #1889 which should be landing sometime today or tomorrow.

Ahh, got it. That's fine then.

Copy link
Contributor

@joecummings joecummings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Nayef211 Nayef211 merged commit 6c1708f into pytorch:main Sep 15, 2022
@Nayef211 Nayef211 deleted the cherry_pick_mask_checking branch September 15, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants