[Cherry Pick] Turn off mask checking for torchtext which is known to have a legal mask (#1896) #1906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ask (pytorch#1896) Summary: Pull Request resolved: pytorch#1896 Turn off mask checking for torchtext which is known to have a legal mask Reviewed By: zrphercule Differential Revision: D39445703 fbshipit-source-id: 3f0cacfd39ea11a16c7a06f339872554333b5e97
Nayef211
changed the title
|
Can we create an Issue to track this recurring test failure on MacOS? |
We can, but the error is also already resolved in #1889 which should be landing sometime today or tomorrow. |
Ahh, got it. That's fine then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request resolved: #1896
Turn off mask checking for torchtext which is known to have a legal mask
Reviewed By: zrphercule
Differential Revision: D39445703
fbshipit-source-id: 3f0cacfd39ea11a16c7a06f339872554333b5e97