Skip to content

Issue templates #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 12, 2019
Merged

Conversation

zhangguanheng66
Copy link
Contributor

Create some issue templates, similar to PyTorch, and help our users to bring up issue.

@zhangguanheng66 zhangguanheng66 requested a review from vincentqb July 1, 2019 14:38
Copy link
Contributor

@cpuhrsch cpuhrsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is mostly a copy-paste from pytorch, which is fine.

It'd be nice to have the collect_env.py function exposed within pytorch and used from there so we don't miss out on subtle bug fixes etc. - Let's mark that as a follow-up task?

@zhangguanheng66
Copy link
Contributor Author

I'm assuming this is mostly a copy-paste from pytorch, which is fine.

It'd be nice to have the collect_env.py function exposed within pytorch and used from there so we don't miss out on subtle bug fixes etc. - Let's mark that as a follow-up task?

Personally, I would like to leave the collect_env.py file in pytorch without carrying it. I just need to have the information of torchtext version.

@zhangguanheng66 zhangguanheng66 merged commit 284a516 into pytorch:master Jul 12, 2019
@zhangguanheng66 zhangguanheng66 deleted the issue_template branch July 22, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants